-
Notifications
You must be signed in to change notification settings - Fork 0
M1 build #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
M1 build #2
Conversation
a70cc93
to
14734e2
Compare
@smokestacklightnin Please take a look |
.github/workflows/build.yml
Outdated
- name: Build wheels | ||
uses: pypa/[email protected] | ||
# env: | ||
# CIBW_SOME_OPTION: value | ||
# ... | ||
# with: | ||
# package-dir: . | ||
# output-dir: wheelhouse | ||
# config-file: "{package}/pyproject.toml" | ||
|
||
- name: Upload to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1.9 | ||
with: | ||
packages_dir: wheels/ | ||
- uses: actions/upload-artifact@v4 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you decided to use cibuildwheel here only, instead of replacing the logic in reusable-build
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah a couple of reasons:
- the reusable-build workflow is redundant in that it builds the code for every single workflow instead of it just building once.
- I want to ensure that the wheels that will be uploaded to pypi are the wheels that are tested.
Before I push this PR up to the main fork, I am actually planning on removing the reusable-build and test workflows since it is already tested as part of the cibuildwheel pipeline.
# default=">=1.17.1,<1.18", | ||
# nightly=">=1.18.0.dev", | ||
# git_master="@git+https://github.com/tensorflow/tfx-bsl@master", | ||
# ), | ||
], | ||
extras_require={ | ||
"mutual-information": _make_mutual_information_requirements(), | ||
"visualization": _make_visualization_requirements(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind please adding the dev and test dependencies to all in the same way that the others have been in order to maintain existing convention
No description provided.